Fixed DynamicGridCheckBoxColumn and general warning fixes

InABox.Core/Configuration/GlobalConfiguration.cs

@@ -51,7 +51,7 @@ namespace InABox.Configuration
             return result ?? NewSettings();
         }
 
-        object IGlobalConfiguration.Load(bool useCache = true) => Load(useCache);
+        object IGlobalConfiguration.Load(bool useCache) => Load(useCache);
         
         public override T Load(bool useCache = true)
         {

InABox.Core/CoreExpression.cs

@@ -5,7 +5,6 @@ using InABox.Clients;
 using System.Diagnostics.CodeAnalysis;
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using System.Text;
 

InABox.Core/CoreUtils.cs

@@ -13,7 +13,6 @@ using System.Net.Mail;
 using System.Reflection;
 using System.Text;
 using System.Text.RegularExpressions;
-using System.Diagnostics.CodeAnalysis;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
 using System.Runtime.CompilerServices;
@@ -277,6 +276,8 @@ namespace InABox.Core
             return result;
         }
 
+        #region Reflection
+
         public static bool HasInterface(this Type type, Type interfaceType)
         {
             return type.GetInterfaces(interfaceType).Any();
@@ -332,6 +333,9 @@ namespace InABox.Core
 
             return null;
         }
+
+        #endregion
+
         public static bool TryGetEntity(string entityname, [NotNullWhen(true)] out Type? type)
         {
             if (string.IsNullOrWhiteSpace(entityname))

InABox.Core/DatabaseSchema/IProperty.cs

@@ -77,6 +77,7 @@ namespace InABox.Core
         {
             return property.Parent != null && (property.Parent.HasEditor || property.Parent.HasParentEditor());
         }
+
         public static bool HasParentEntityLink(this IProperty property)
         {
             return property.Parent != null && (property.Parent.IsEntityLink || property.Parent.HasParentEntityLink());

InABox.Core/DigitalForms/DataModel/DigitalFormDataModel.cs

@@ -39,7 +39,7 @@ namespace InABox.Core
             {
                 return CoreUtils.GetPropertyValue(Entity, name);
             }
-            catch (Exception e)
+            catch
             {
                 return null;
             }

InABox.Core/DigitalForms/Forms/DigitalFormLayout.cs

@@ -45,7 +45,7 @@ namespace InABox.Core
             return new Filter<DigitalFormLayout>(x => x.Form.ID).IsEqualTo(Form.ID);
         }
 
-        public string? AutoIncrementPrefix() => "L";
+        public string AutoIncrementPrefix() => "L";
 
         public string AutoIncrementFormat()
         {

InABox.Core/DigitalForms/Forms/DigitalFormVariable.cs

@@ -108,7 +108,7 @@ namespace InABox.Core
             return new Filter<DigitalFormVariable>(x => x.Form.ID).IsEqualTo(Form.ID);
         }
 
-        public string? AutoIncrementPrefix() => "V";
+        public string AutoIncrementPrefix() => "V";
 
         public string AutoIncrementFormat()
         {

InABox.Core/DigitalForms/Layouts/Fields/DFLayoutURLField/DFLayoutURLFieldProperties.cs

@@ -17,9 +17,9 @@
             entry.SetValue(value);
         }
 
-        public override string GetValue(string value)
+        public override string GetValue(string? value)
         {
-            return value;
+            return value ?? "";
         }
     }
 }

InABox.Core/DigitalForms/Obsolete/QAQuestion.cs

@@ -48,7 +48,7 @@ namespace InABox.Core
         [NullEditor]
         public long Sequence { get; set; }
 
-        protected override void DoPropertyChanged(string name, object before, object after)
+        protected override void DoPropertyChanged(string name, object? before, object? after)
         {
             base.DoPropertyChanged(name, before, after);
             if (name.Equals("Answer"))

InABox.Core/Editors/TextBoxEditor.cs

@@ -7,7 +7,7 @@
             Visible = Visible.Default;
         }
 
-        public EditorButton[] Buttons { get; set; }
+        public EditorButton[]? Buttons { get; set; }
 
         protected override BaseEditor DoClone()
         {

InABox.Core/EnclosedEntity.cs

@@ -26,7 +26,7 @@ namespace InABox.Core
             _linkedentity = entity;
         }
         
-        protected override void DoPropertyChanged(string name, object before, object after)
+        protected override void DoPropertyChanged(string name, object? before, object? after)
         {
             var le = LinkedEntity();
             if (IsObserving() && le != null)

inabox.wpf/DynamicGrid/Columns/EditorColumns/DynamicGridCheckBoxColumn.cs

@@ -23,7 +23,7 @@ public class DynamicGridCheckBoxColumn<TEntity> : DynamicGridEditorColumn<TEntit
             () =>
             {
                 var result = new Image() { Source = tick, Margin = new Thickness(2) };
-                var binding = new Binding() { Path = new PropertyPath(MappingName) };
+                var binding = new Binding() { Path = new PropertyPath(MappingName), Converter = new BooleanToVisibilityConverter() };
                 result.SetBinding(UIElement.VisibilityProperty, binding);
                 return result;
             }